1
0
mirror of https://github.com/scrapy/scrapy.git synced 2025-02-25 02:03:50 +00:00

document issue with FormRequest.from_response due to bug in lxml

This can make the spider fail due to incorrect values being posted
server-side, which is extremely hard to debug because it is easy
to miss leading/trailing whitespace, even with a logging proxy.

The fix was merged for lxml 3.8 in lxml/lxml#228 so document that
as well.
This commit is contained in:
Ashish Kulkarni 2017-02-17 14:54:22 +05:30
parent afac3fd2c2
commit 165e2cb8c9

View File

@ -376,6 +376,10 @@ fields with form data from :class:`Response` objects.
control clicked (instead of disabling it) you can also use the
``clickdata`` argument.
.. caution:: Using this method with select elements which have leading
or trailing whitespace in the option values will not work due to a
`bug in lxml`_, which should be fixed in lxml 3.8 and above.
:param response: the response containing a HTML form which will be used
to pre-populate the form fields
:type response: :class:`Response` object
@ -710,3 +714,4 @@ XmlResponse objects
line. See :attr:`TextResponse.encoding`.
.. _Twisted Failure: https://twistedmatrix.com/documents/current/api/twisted.python.failure.Failure.html
.. _bug in lxml: https://bugs.launchpad.net/lxml/+bug/1665241