From 3e4bc6141aff1aa7e04844712f720aa0dfb71214 Mon Sep 17 00:00:00 2001 From: Daniel Grana Date: Thu, 12 Feb 2009 07:39:57 +0000 Subject: [PATCH] core: remove obsolte groupfilter code --HG-- extra : convert_revision : svn%3Ab85faa78-f9eb-468e-a121-7cced6da292c%40847 --- .../trunk/scrapy/core/scheduler/__init__.py | 1 - scrapy/trunk/scrapy/core/scheduler/filter.py | 19 ------------- scrapy/trunk/scrapy/tests/test_groupfilter.py | 27 ------------------- 3 files changed, 47 deletions(-) delete mode 100644 scrapy/trunk/scrapy/core/scheduler/filter.py delete mode 100644 scrapy/trunk/scrapy/tests/test_groupfilter.py diff --git a/scrapy/trunk/scrapy/core/scheduler/__init__.py b/scrapy/trunk/scrapy/core/scheduler/__init__.py index 1027c0382..35ed94303 100644 --- a/scrapy/trunk/scrapy/core/scheduler/__init__.py +++ b/scrapy/trunk/scrapy/core/scheduler/__init__.py @@ -1,3 +1,2 @@ from scrapy.core.scheduler.schedulers import Scheduler -from scrapy.core.scheduler.filter import GroupFilter from scrapy.core.scheduler.store import MemoryStore diff --git a/scrapy/trunk/scrapy/core/scheduler/filter.py b/scrapy/trunk/scrapy/core/scheduler/filter.py deleted file mode 100644 index 9008a4d03..000000000 --- a/scrapy/trunk/scrapy/core/scheduler/filter.py +++ /dev/null @@ -1,19 +0,0 @@ -class GroupFilter(dict): - """Filter groups of keys""" - def open(self, group): - self[group] = set() - - def close(self, group): - del self[group] - - def add(self, group, key): - """Add a key to the group if an equivalent key has not already been added. - This method will return true if the key was added and false otherwise. - """ - if key not in self[group]: - self[group].add(key) - return True - return False - - def has(self, group, key): - return key in self[group] diff --git a/scrapy/trunk/scrapy/tests/test_groupfilter.py b/scrapy/trunk/scrapy/tests/test_groupfilter.py deleted file mode 100644 index 4ff2ff644..000000000 --- a/scrapy/trunk/scrapy/tests/test_groupfilter.py +++ /dev/null @@ -1,27 +0,0 @@ -import unittest -from scrapy.core.scheduler import GroupFilter - -class GroupFilterTest(unittest.TestCase): - - def test_groupfilter(self): - k1 = "id1" - k2 = "id1" - - f = GroupFilter() - f.open("mygroup") - self.assertTrue(f.add("mygroup", k1)) - self.assertFalse(f.add("mygroup", k1)) - self.assertFalse(f.add("mygroup", k2)) - - f.open('anothergroup') - self.assertTrue(f.add("anothergroup", k1)) - self.assertFalse(f.add("anothergroup", k1)) - self.assertFalse(f.add("anothergroup", k2)) - - f.close('mygroup') - f.open('mygroup') - self.assertTrue(f.add("mygroup", k2)) - self.assertFalse(f.add("mygroup", k1)) - -if __name__ == "__main__": - unittest.main()