BackTrackZ/scrapy
BackTrackZ/scrapy
1
0
Fork 0
mirror of https://github.com/scrapy/scrapy.git synced 2025-02-22 17:44:00 +00:00
Code Releases Wiki Activity

[logformatter] backward compat comments

Browse Source
This commit is contained in:
Pawel Miech 2017-03-17 08:11:20 +01:00
parent 0f2a5cdb8e
commit 4345eaf1b6
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
scrapy/logformatter.py
View File

@ -43,6 +43,7 @@ class LogFormatter(object):
'request_flags' : request_flags, 'request_flags' : request_flags,
'referer': referer_str(request), 'referer': referer_str(request),
'response_flags': response_flags, 'response_flags': response_flags,
# backward compatibility with Scrapy logformatter below 1.4 version
'flags': response_flags 'flags': response_flags
} }
} }

2
tests/test_logformatter.py
View File

@ -66,7 +66,6 @@ class LoggingContribTest(unittest.TestCase):
class LogFormatterSubclass(LogFormatter): class LogFormatterSubclass(LogFormatter):
# Formatter with format spec that is same as in Scrapy before 1.3 version.
def crawled(self, request, response, spider): def crawled(self, request, response, spider):
kwargs = super(LogFormatterSubclass, self).crawled( kwargs = super(LogFormatterSubclass, self).crawled(
request, response, spider) request, response, spider)
@ -82,7 +81,6 @@ class LogFormatterSubclass(LogFormatter):
class LogformatterSubclassTest(LoggingContribTest): class LogformatterSubclassTest(LoggingContribTest):
# Test if old crawledmsg format string still works fine
def setUp(self): def setUp(self):
self.formatter = LogFormatterSubclass() self.formatter = LogFormatterSubclass()
self.spider = Spider('default') self.spider = Spider('default')