From 1968a8ec02913273a99a3137cb419e2649d69a5f Mon Sep 17 00:00:00 2001 From: Paul Tremberth Date: Wed, 23 Aug 2017 15:08:10 +0200 Subject: [PATCH] Move logging of overriden settings to Crawler init --- scrapy/crawler.py | 5 ++++- scrapy/utils/log.py | 4 +--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/scrapy/crawler.py b/scrapy/crawler.py index 1367536ab..0a56ef57a 100644 --- a/scrapy/crawler.py +++ b/scrapy/crawler.py @@ -11,7 +11,7 @@ from scrapy.core.engine import ExecutionEngine from scrapy.resolver import CachingThreadedResolver from scrapy.interfaces import ISpiderLoader from scrapy.extension import ExtensionManager -from scrapy.settings import Settings +from scrapy.settings import overridden_settings, Settings from scrapy.signalmanager import SignalManager from scrapy.exceptions import ScrapyDeprecationWarning from scrapy.utils.ossignal import install_shutdown_handlers, signal_names @@ -34,6 +34,9 @@ class Crawler(object): self.settings = settings.copy() self.spidercls.update_settings(self.settings) + d = dict(overridden_settings(self.settings)) + logger.info("Overridden settings: %(settings)r", {'settings': d}) + self.signals = SignalManager(self) self.stats = load_object(self.settings['STATS_CLASS'])(self) diff --git a/scrapy/utils/log.py b/scrapy/utils/log.py index 905c1bfc1..c6d1cdf46 100644 --- a/scrapy/utils/log.py +++ b/scrapy/utils/log.py @@ -9,7 +9,7 @@ from twisted.python.failure import Failure from twisted.python import log as twisted_log import scrapy -from scrapy.settings import overridden_settings, Settings +from scrapy.settings import Settings from scrapy.exceptions import ScrapyDeprecationWarning from scrapy.utils.versions import scrapy_components_versions @@ -148,8 +148,6 @@ def log_scrapy_info(settings): {'versions': ", ".join("%s %s" % (name, version) for name, version in scrapy_components_versions() if name != "Scrapy")}) - d = dict(overridden_settings(settings)) - logger.info("Overridden settings: %(settings)r", {'settings': d}) class StreamLogger(object):