From 7232c31f78358741f3b7c532bdc268d43ff51622 Mon Sep 17 00:00:00 2001 From: Simon Ratner Date: Fri, 11 Nov 2011 11:53:00 -0800 Subject: [PATCH] Delete old logs based on file mtime. --- scrapyd/environ.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scrapyd/environ.py b/scrapyd/environ.py index 8b208d76e..0f2fc89c8 100644 --- a/scrapyd/environ.py +++ b/scrapyd/environ.py @@ -37,7 +37,7 @@ class Environment(object): message['_spider']) if not os.path.exists(logsdir): os.makedirs(logsdir) - to_delete = sorted(os.listdir(logsdir), reverse=True)[:-self.logs_to_keep] + to_delete = sorted((os.path.join(logsdir, x) for x in os.listdir(logsdir)), key=os.path.getmtime)[:-self.logs_to_keep] for x in to_delete: - os.remove(os.path.join(logsdir, x)) + os.remove(x) return os.path.join(logsdir, "%s.log" % message['_job'])