1
0
mirror of https://github.com/scrapy/scrapy.git synced 2025-02-21 06:33:07 +00:00

Use create_instance in FTPDownloadHandler/DataURIDownloadHandler tests

This commit is contained in:
Eugenio Lacuesta 2019-12-23 10:02:58 -03:00
parent fa21d8687a
commit 7e6387de40
No known key found for this signature in database
GPG Key ID: DA3EF2D0913E9810

View File

@ -984,7 +984,8 @@ class BaseFTPTestCase(unittest.TestCase):
self.factory = FTPFactory(portal=p)
self.port = reactor.listenTCP(0, self.factory, interface="127.0.0.1")
self.portNum = self.port.getHost().port
self.download_handler = FTPDownloadHandler(get_crawler())
crawler = get_crawler()
self.download_handler = create_instance(FTPDownloadHandler, crawler.settings, crawler)
self.addCleanup(self.port.stopListening)
def tearDown(self):
@ -1098,7 +1099,8 @@ class AnonymousFTPTestCase(BaseFTPTestCase):
userAnonymous=self.username)
self.port = reactor.listenTCP(0, self.factory, interface="127.0.0.1")
self.portNum = self.port.getHost().port
self.download_handler = FTPDownloadHandler(get_crawler())
crawler = get_crawler()
self.download_handler = create_instance(FTPDownloadHandler, crawler.settings, crawler)
self.addCleanup(self.port.stopListening)
def tearDown(self):
@ -1108,7 +1110,8 @@ class AnonymousFTPTestCase(BaseFTPTestCase):
class DataURITestCase(unittest.TestCase):
def setUp(self):
self.download_handler = DataURIDownloadHandler()
crawler = get_crawler()
self.download_handler = create_instance(DataURIDownloadHandler, crawler.settings, crawler)
self.download_request = self.download_handler.download_request
self.spider = Spider('foo')