1
0
mirror of https://github.com/scrapy/scrapy.git synced 2025-02-21 06:13:09 +00:00

Keyword-only args for S3DownloadHandler

This commit is contained in:
Eugenio Lacuesta 2019-12-23 20:37:18 -03:00
parent 982a66f9fb
commit ab54e0d33e
No known key found for this signature in database
GPG Key ID: DA3EF2D0913E9810

View File

@ -33,7 +33,8 @@ def _get_boto_connection():
class S3DownloadHandler:
def __init__(self, settings, crawler=None,
def __init__(self, settings, *,
crawler=None,
aws_access_key_id=None, aws_secret_access_key=None,
httpdownloadhandler=HTTPDownloadHandler, **kw):
if not aws_access_key_id:
@ -76,8 +77,8 @@ class S3DownloadHandler:
self._download_http = _http_handler.download_request
@classmethod
def from_crawler(cls, crawler, *args, **kwargs):
return cls(crawler.settings, crawler, *args, **kwargs)
def from_crawler(cls, crawler, **kwargs):
return cls(crawler.settings, crawler=crawler, **kwargs)
def download_request(self, request, spider):
p = urlparse_cached(request)