From b7c9503d9cd94e6aa1023a41fe86a64526aa134c Mon Sep 17 00:00:00 2001 From: Pablo Hoffman Date: Tue, 26 Oct 2010 16:50:34 -0200 Subject: [PATCH] disable lxml selectors tests which was failing on certain versions of lxml-libxml2 --- scrapy/tests/test_selector_lxml.py | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/scrapy/tests/test_selector_lxml.py b/scrapy/tests/test_selector_lxml.py index 8a079ef1e..b16a2e2bf 100644 --- a/scrapy/tests/test_selector_lxml.py +++ b/scrapy/tests/test_selector_lxml.py @@ -208,15 +208,19 @@ class XPathSelectorTestCase(unittest.TestCase): self.assertEquals(x.select("//span[@id='blank']/text()").extract(), [u'\xa3']) - @libxml2debug - def test_null_bytes(self): - hxs = HtmlXPathSelector(text='la\x00la') - self.assertEqual(hxs.extract(), - u'la la') - - xxs = XmlXPathSelector(text='la\x00la') - self.assertEqual(xxs.extract(), - u'la') + # XXX: this test was disabled because lxml behaves inconsistently when + # handling null bytes between different 2.2.x versions, but it may be due + # to differences in libxml2 too. it's also unclear what should be the + # proper behaviour (pablo - 26 oct 2010) + #@libxml2debug + #def test_null_bytes(self): + # hxs = HtmlXPathSelector(text='la\x00la') + # self.assertEqual(hxs.extract(), + # u'la') + # + # xxs = XmlXPathSelector(text='la\x00la') + # self.assertEqual(xxs.extract(), + # u'la') @libxml2debug def test_unquote(self):