mirror of
https://github.com/scrapy/scrapy.git
synced 2025-02-06 10:24:24 +00:00
ba5df629a2
* Make download handler test base classes abstract. * Small cleanup. * Don't run the full test suite for special HTTP cases. * Don't run tests in imported base classes. * Remove an obsolete service_identity check. * Move FTP imports back to the top level. * Simplify the H2DownloadHandler import. * Forbig pytest 8.2.x. * Revert "Simplify the H2DownloadHandler import." This reverts commit ed187046ac53c395c7423c0f5e6fb2bc7c27838f.
253 lines
8.9 KiB
Python
253 lines
8.9 KiB
Python
import json
|
|
from unittest import mock
|
|
|
|
import pytest
|
|
from testfixtures import LogCapture
|
|
from twisted.internet import defer, error, reactor
|
|
from twisted.trial import unittest
|
|
from twisted.web import server
|
|
from twisted.web.error import SchemeNotSupported
|
|
from twisted.web.http import H2_ENABLED
|
|
|
|
from scrapy.core.downloader.handlers import DownloadHandlerProtocol
|
|
from scrapy.http import Request
|
|
from scrapy.spiders import Spider
|
|
from scrapy.utils.misc import build_from_crawler
|
|
from scrapy.utils.test import get_crawler
|
|
from tests.mockserver import ssl_context_factory
|
|
from tests.test_downloader_handlers import (
|
|
UriResource,
|
|
)
|
|
|
|
pytestmark = pytest.mark.skipif(
|
|
not H2_ENABLED, reason="HTTP/2 support in Twisted is not enabled"
|
|
)
|
|
|
|
|
|
class BaseTestClasses:
|
|
# A hack to prevent tests from the imported classes to run here too.
|
|
# See https://stackoverflow.com/q/1323455/113586 for other ways.
|
|
from tests.test_downloader_handlers import (
|
|
Http11MockServerTestCase as Http11MockServerTestCase,
|
|
)
|
|
from tests.test_downloader_handlers import (
|
|
Http11ProxyTestCase as Http11ProxyTestCase,
|
|
)
|
|
from tests.test_downloader_handlers import (
|
|
Https11CustomCiphers as Https11CustomCiphers,
|
|
)
|
|
from tests.test_downloader_handlers import (
|
|
Https11InvalidDNSId as Https11InvalidDNSId,
|
|
)
|
|
from tests.test_downloader_handlers import (
|
|
Https11InvalidDNSPattern as Https11InvalidDNSPattern,
|
|
)
|
|
from tests.test_downloader_handlers import (
|
|
Https11TestCase as Https11TestCase,
|
|
)
|
|
from tests.test_downloader_handlers import (
|
|
Https11WrongHostnameTestCase as Https11WrongHostnameTestCase,
|
|
)
|
|
|
|
|
|
def _get_dh() -> type[DownloadHandlerProtocol]:
|
|
from scrapy.core.downloader.handlers.http2 import H2DownloadHandler
|
|
|
|
return H2DownloadHandler
|
|
|
|
|
|
class Https2TestCase(BaseTestClasses.Https11TestCase):
|
|
scheme = "https"
|
|
HTTP2_DATALOSS_SKIP_REASON = "Content-Length mismatch raises InvalidBodyLengthError"
|
|
|
|
@property
|
|
def download_handler_cls(self) -> type[DownloadHandlerProtocol]:
|
|
return _get_dh()
|
|
|
|
def test_protocol(self):
|
|
request = Request(self.getURL("host"), method="GET")
|
|
d = self.download_request(request, Spider("foo"))
|
|
d.addCallback(lambda r: r.protocol)
|
|
d.addCallback(self.assertEqual, "h2")
|
|
return d
|
|
|
|
@defer.inlineCallbacks
|
|
def test_download_with_maxsize_very_large_file(self):
|
|
with mock.patch("scrapy.core.http2.stream.logger") as logger:
|
|
request = Request(self.getURL("largechunkedfile"))
|
|
|
|
def check(logger):
|
|
logger.error.assert_called_once_with(mock.ANY)
|
|
|
|
d = self.download_request(request, Spider("foo", download_maxsize=1500))
|
|
yield self.assertFailure(d, defer.CancelledError, error.ConnectionAborted)
|
|
|
|
# As the error message is logged in the dataReceived callback, we
|
|
# have to give a bit of time to the reactor to process the queue
|
|
# after closing the connection.
|
|
d = defer.Deferred()
|
|
d.addCallback(check)
|
|
reactor.callLater(0.1, d.callback, logger)
|
|
yield d
|
|
|
|
@defer.inlineCallbacks
|
|
def test_unsupported_scheme(self):
|
|
request = Request("ftp://unsupported.scheme")
|
|
d = self.download_request(request, Spider("foo"))
|
|
yield self.assertFailure(d, SchemeNotSupported)
|
|
|
|
def test_download_broken_content_cause_data_loss(self, url="broken"):
|
|
raise unittest.SkipTest(self.HTTP2_DATALOSS_SKIP_REASON)
|
|
|
|
def test_download_broken_chunked_content_cause_data_loss(self):
|
|
raise unittest.SkipTest(self.HTTP2_DATALOSS_SKIP_REASON)
|
|
|
|
def test_download_broken_content_allow_data_loss(self, url="broken"):
|
|
raise unittest.SkipTest(self.HTTP2_DATALOSS_SKIP_REASON)
|
|
|
|
def test_download_broken_chunked_content_allow_data_loss(self):
|
|
raise unittest.SkipTest(self.HTTP2_DATALOSS_SKIP_REASON)
|
|
|
|
def test_download_broken_content_allow_data_loss_via_setting(self, url="broken"):
|
|
raise unittest.SkipTest(self.HTTP2_DATALOSS_SKIP_REASON)
|
|
|
|
def test_download_broken_chunked_content_allow_data_loss_via_setting(self):
|
|
raise unittest.SkipTest(self.HTTP2_DATALOSS_SKIP_REASON)
|
|
|
|
def test_concurrent_requests_same_domain(self):
|
|
spider = Spider("foo")
|
|
|
|
request1 = Request(self.getURL("file"))
|
|
d1 = self.download_request(request1, spider)
|
|
d1.addCallback(lambda r: r.body)
|
|
d1.addCallback(self.assertEqual, b"0123456789")
|
|
|
|
request2 = Request(self.getURL("echo"), method="POST")
|
|
d2 = self.download_request(request2, spider)
|
|
d2.addCallback(lambda r: r.headers["Content-Length"])
|
|
d2.addCallback(self.assertEqual, b"79")
|
|
|
|
return defer.DeferredList([d1, d2])
|
|
|
|
@pytest.mark.xfail(reason="https://github.com/python-hyper/h2/issues/1247")
|
|
def test_connect_request(self):
|
|
request = Request(self.getURL("file"), method="CONNECT")
|
|
d = self.download_request(request, Spider("foo"))
|
|
d.addCallback(lambda r: r.body)
|
|
d.addCallback(self.assertEqual, b"")
|
|
return d
|
|
|
|
def test_custom_content_length_good(self):
|
|
request = Request(self.getURL("contentlength"))
|
|
custom_content_length = str(len(request.body))
|
|
request.headers["Content-Length"] = custom_content_length
|
|
d = self.download_request(request, Spider("foo"))
|
|
d.addCallback(lambda r: r.text)
|
|
d.addCallback(self.assertEqual, custom_content_length)
|
|
return d
|
|
|
|
def test_custom_content_length_bad(self):
|
|
request = Request(self.getURL("contentlength"))
|
|
actual_content_length = str(len(request.body))
|
|
bad_content_length = str(len(request.body) + 1)
|
|
request.headers["Content-Length"] = bad_content_length
|
|
log = LogCapture()
|
|
d = self.download_request(request, Spider("foo"))
|
|
d.addCallback(lambda r: r.text)
|
|
d.addCallback(self.assertEqual, actual_content_length)
|
|
d.addCallback(
|
|
lambda _: log.check_present(
|
|
(
|
|
"scrapy.core.http2.stream",
|
|
"WARNING",
|
|
f"Ignoring bad Content-Length header "
|
|
f"{bad_content_length!r} of request {request}, sending "
|
|
f"{actual_content_length!r} instead",
|
|
)
|
|
)
|
|
)
|
|
d.addCallback(lambda _: log.uninstall())
|
|
return d
|
|
|
|
def test_duplicate_header(self):
|
|
request = Request(self.getURL("echo"))
|
|
header, value1, value2 = "Custom-Header", "foo", "bar"
|
|
request.headers.appendlist(header, value1)
|
|
request.headers.appendlist(header, value2)
|
|
d = self.download_request(request, Spider("foo"))
|
|
d.addCallback(lambda r: json.loads(r.text)["headers"][header])
|
|
d.addCallback(self.assertEqual, [value1, value2])
|
|
return d
|
|
|
|
|
|
class Https2WrongHostnameTestCase(BaseTestClasses.Https11WrongHostnameTestCase):
|
|
@property
|
|
def download_handler_cls(self) -> type[DownloadHandlerProtocol]:
|
|
return _get_dh()
|
|
|
|
|
|
class Https2InvalidDNSId(BaseTestClasses.Https11InvalidDNSId):
|
|
@property
|
|
def download_handler_cls(self) -> type[DownloadHandlerProtocol]:
|
|
return _get_dh()
|
|
|
|
|
|
class Https2InvalidDNSPattern(BaseTestClasses.Https11InvalidDNSPattern):
|
|
@property
|
|
def download_handler_cls(self) -> type[DownloadHandlerProtocol]:
|
|
return _get_dh()
|
|
|
|
|
|
class Https2CustomCiphers(BaseTestClasses.Https11CustomCiphers):
|
|
@property
|
|
def download_handler_cls(self) -> type[DownloadHandlerProtocol]:
|
|
return _get_dh()
|
|
|
|
|
|
class Http2MockServerTestCase(BaseTestClasses.Http11MockServerTestCase):
|
|
"""HTTP 2.0 test case with MockServer"""
|
|
|
|
settings_dict = {
|
|
"DOWNLOAD_HANDLERS": {
|
|
"https": "scrapy.core.downloader.handlers.http2.H2DownloadHandler"
|
|
}
|
|
}
|
|
is_secure = True
|
|
|
|
|
|
class Https2ProxyTestCase(BaseTestClasses.Http11ProxyTestCase):
|
|
# only used for HTTPS tests
|
|
keyfile = "keys/localhost.key"
|
|
certfile = "keys/localhost.crt"
|
|
|
|
scheme = "https"
|
|
host = "127.0.0.1"
|
|
|
|
expected_http_proxy_request_body = b"/"
|
|
|
|
@property
|
|
def download_handler_cls(self) -> type[DownloadHandlerProtocol]:
|
|
return _get_dh()
|
|
|
|
def setUp(self):
|
|
site = server.Site(UriResource(), timeout=None)
|
|
self.port = reactor.listenSSL(
|
|
0,
|
|
site,
|
|
ssl_context_factory(self.keyfile, self.certfile),
|
|
interface=self.host,
|
|
)
|
|
self.portno = self.port.getHost().port
|
|
self.download_handler = build_from_crawler(
|
|
self.download_handler_cls, get_crawler()
|
|
)
|
|
self.download_request = self.download_handler.download_request
|
|
|
|
def getURL(self, path):
|
|
return f"{self.scheme}://{self.host}:{self.portno}/{path}"
|
|
|
|
@defer.inlineCallbacks
|
|
def test_download_with_proxy_https_timeout(self):
|
|
with self.assertRaises(NotImplementedError):
|
|
yield super().test_download_with_proxy_https_timeout()
|