H0llyW00dzZ/fiber
H0llyW00dzZ/fiber
1
0
Fork 0
mirror of https://github.com/gofiber/fiber.git synced 2025-02-23 01:43:54 +00:00
Code Releases Activity

🐛 session should not regenerate the ID in case Get() returned nil (#1493)

Browse Source 
* fix: session should not regenerate the ID in case Get() returned nil

* fix: prevent falsy unit-tests

* docs: improve wordings on tests
This commit is contained in:
Bhurinat Wangsutthitham 2021-08-23 13:32:14 +07:00 committed by GitHub
parent bff8843abd
commit 0e08bb4fe7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
middleware/session/session_test.go
View File

@ -61,31 +61,30 @@ func Test_Session(t *testing.T) {
keys = sess.Keys()
utils.AssertEqual(t, []string{}, keys)
// we do not get id here
// since the original id is not in the db
// sess.id must be a new-generated uuid, which is not equivalent to "123"
// id := sess.ID()
// utils.AssertEqual(t, "123", id)
// delete cookie
ctx.Request().Header.Del(fiber.HeaderCookie)
// get session
sess, err = store.Get(ctx)
utils.AssertEqual(t, nil, err)
utils.AssertEqual(t, true, sess.Fresh())
// get id
id := sess.ID()
utils.AssertEqual(t, 36, len(id))
// when we use the session for the second time
// the session be should be same if the session is not expired
utils.AssertEqual(t, "123", id)
// save the old session first
err = sess.Save()
utils.AssertEqual(t, nil, err)
// requesting entirely new context to prevent falsy tests
ctx = app.AcquireCtx(&fasthttp.RequestCtx{})
defer app.ReleaseCtx(ctx)
sess, err = store.Get(ctx)
utils.AssertEqual(t, nil, err)
utils.AssertEqual(t, true, sess.Fresh())
// this id should be randomly generated as session key was deleted
utils.AssertEqual(t, 36, len(sess.ID()))
// when we use the original session for the second time
// the session be should be same if the session is not expired
ctx = app.AcquireCtx(&fasthttp.RequestCtx{})
defer app.ReleaseCtx(ctx)
// request the server with the old session
ctx.Request().Header.SetCookie(store.sessionName, id)
sess, err = store.Get(ctx)
@ -124,7 +123,7 @@ func Test_Session_Types(t *testing.T) {
Name string
}
store.RegisterType(User{})
var vuser = User{
vuser := User{
Name: "John",
}
// set value

8
middleware/session/store.go
View File

@ -38,7 +38,7 @@ func (s *Store) RegisterType(i interface{}) {
// Get will get/create a session
func (s *Store) Get(c *fiber.Ctx) (*Session, error) {
var fresh bool
var loadData = true
loadData := true
id := s.getSessionID(c)
@ -79,10 +79,8 @@ func (s *Store) Get(c *fiber.Ctx) (*Session, error) {
} else if err != nil {
return nil, err
} else {
// raw is nil, which means id is not in the storage
// so it means that id is not valid (mainly because of id is expired or user provides an invalid id)
// therefore, we regenerate a id
sess.refresh()
// both raw and err is nil, which means id is not in the storage
sess.fresh = true
}
}

4
middleware/session/store_test.go
View File

@ -63,7 +63,7 @@ func TestStore_Get(t *testing.T) {
unexpectedID := "test-session-id"
// fiber instance
app := fiber.New()
t.Run("regenerate a session when session is invalid", func(t *testing.T) {
t.Run("session should persisted even session is invalid", func(t *testing.T) {
// session store
store := New()
// fiber context
@ -75,7 +75,7 @@ func TestStore_Get(t *testing.T) {
acquiredSession, err := store.Get(ctx)
utils.AssertEqual(t, err, nil)
if acquiredSession.ID() == unexpectedID {
if acquiredSession.ID() != unexpectedID {
t.Fatal("server should not accept the unexpectedID which is not in the store")
}
})