From e8c3a0fac388805ddc559f6721d293e3cbc63ada Mon Sep 17 00:00:00 2001 From: Abhishek Kumar <43061995+xenowits@users.noreply.github.com> Date: Sun, 24 Jan 2021 13:11:46 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=A9=B9=20Fix:=20add=20separate=20test=20f?= =?UTF-8?q?or=20resBody=20logger=20variable?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- middleware/logger/logger_test.go | 37 ++++++++++++++++++++++++++++---- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/middleware/logger/logger_test.go b/middleware/logger/logger_test.go index 51b7ed62..ca4157b3 100644 --- a/middleware/logger/logger_test.go +++ b/middleware/logger/logger_test.go @@ -149,14 +149,33 @@ func Test_Logger_All(t *testing.T) { utils.AssertEqual(t, expected, buf.String()) } -// go test -run Test_Query_Params_Response_Body +// go test -run Test_Query_Params func Test_Query_Params(t *testing.T) { buf := bytebufferpool.Get() defer bytebufferpool.Put(buf) app := fiber.New() app.Use(New(Config{ - Format: "${queryParams}${resBody}", + Format: "${queryParams}", + Output: buf, + })) + + resp, err := app.Test(httptest.NewRequest("GET", "/?foo=bar&baz=moz", nil)) + utils.AssertEqual(t, nil, err) + utils.AssertEqual(t, fiber.StatusNotFound, resp.StatusCode) + + expected := fmt.Sprintf("foo=bar&baz=moz") + utils.AssertEqual(t, expected, buf.String()) +} + +// go test -run Test_Response_Body +func Test_Response_Body(t *testing.T) { + buf := bytebufferpool.Get() + defer bytebufferpool.Put(buf) + + app := fiber.New() + app.Use(New(Config{ + Format: "${resBody}", Output: buf, })) @@ -164,11 +183,21 @@ func Test_Query_Params(t *testing.T) { return c.SendString("Sample response body") }) - _, err := app.Test(httptest.NewRequest("GET", "/?foo=bar&baz=moz", nil)) + app.Post("/test", func(c *fiber.Ctx) error { + return c.Send([]byte("Post in test")) + }) + + _, err := app.Test(httptest.NewRequest("GET", "/", nil)) utils.AssertEqual(t, nil, err) - expected := fmt.Sprintf("foo=bar&baz=mozSample response body") + expected := fmt.Sprintf("Sample response body") utils.AssertEqual(t, expected, buf.String()) + + _, err = app.Test(httptest.NewRequest("POST", "/test", nil)) + utils.AssertEqual(t, nil, err) + + expected = fmt.Sprintf("Post in test") + utils.AssertEqual(t, nil, err) } // go test -run Test_Logger_AppendUint