mirror of
https://github.com/git/git.git
synced 2025-03-16 11:55:16 +00:00
use absolute_pathdup()
Apply the semantic patch for converting callers that duplicate the result of absolute_path() to call absolute_pathdup() instead, which avoids an extra string copy to a static buffer. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
b1edb40f25
commit
0aaad415bc
@ -161,7 +161,7 @@ static char *get_repo_path(const char *repo, int *is_bundle)
|
|||||||
|
|
||||||
strbuf_addstr(&path, repo);
|
strbuf_addstr(&path, repo);
|
||||||
raw = get_repo_path_1(&path, is_bundle);
|
raw = get_repo_path_1(&path, is_bundle);
|
||||||
canon = raw ? xstrdup(absolute_path(raw)) : NULL;
|
canon = raw ? absolute_pathdup(raw) : NULL;
|
||||||
strbuf_release(&path);
|
strbuf_release(&path);
|
||||||
return canon;
|
return canon;
|
||||||
}
|
}
|
||||||
@ -892,7 +892,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
|
|||||||
|
|
||||||
path = get_repo_path(repo_name, &is_bundle);
|
path = get_repo_path(repo_name, &is_bundle);
|
||||||
if (path)
|
if (path)
|
||||||
repo = xstrdup(absolute_path(repo_name));
|
repo = absolute_pathdup(repo_name);
|
||||||
else if (!strchr(repo_name, ':'))
|
else if (!strchr(repo_name, ':'))
|
||||||
die(_("repository '%s' does not exist"), repo_name);
|
die(_("repository '%s' does not exist"), repo_name);
|
||||||
else
|
else
|
||||||
|
@ -515,7 +515,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
|
|||||||
module_clone_options);
|
module_clone_options);
|
||||||
|
|
||||||
strbuf_addf(&sb, "%s/modules/%s", get_git_dir(), name);
|
strbuf_addf(&sb, "%s/modules/%s", get_git_dir(), name);
|
||||||
sm_gitdir = xstrdup(absolute_path(sb.buf));
|
sm_gitdir = absolute_pathdup(sb.buf);
|
||||||
strbuf_reset(&sb);
|
strbuf_reset(&sb);
|
||||||
|
|
||||||
if (!is_absolute_path(path)) {
|
if (!is_absolute_path(path)) {
|
||||||
|
@ -158,7 +158,7 @@ done:
|
|||||||
|
|
||||||
static void mark_current_worktree(struct worktree **worktrees)
|
static void mark_current_worktree(struct worktree **worktrees)
|
||||||
{
|
{
|
||||||
char *git_dir = xstrdup(absolute_path(get_git_dir()));
|
char *git_dir = absolute_pathdup(get_git_dir());
|
||||||
int i;
|
int i;
|
||||||
|
|
||||||
for (i = 0; worktrees[i]; i++) {
|
for (i = 0; worktrees[i]; i++) {
|
||||||
|
Loading…
x
Reference in New Issue
Block a user