H0llyW00dzZ/git
H0llyW00dzZ/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2025-03-16 11:55:16 +00:00
Code Releases Activity

ll-merge: let caller decide whether to renormalize

Browse Source 
Add a “renormalize” bit to the ll-merge options word so callers can
decide on a case-by-case basis whether the merge is likely to have
overlapped with a change in smudge/clean rules.

This reveals a few commands that have not been taking that situation
into account, though it does not fix them.

No functional change intended.

Cc: Eyvind Bernhardsen <eyvind.bernhardsen@gmail.com>
Improved-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jonathan Nieder 2010-08-05 06:24:58 -05:00 committed by Junio C Hamano
parent 73cf7f713d
commit 18b037a5b6
5 changed files with 19 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
builtin/checkout.c
View File

@ -150,6 +150,10 @@ static int checkout_merged(int pos, struct checkout *state)
read_mmblob(&ours, active_cache[pos+1]->sha1); read_mmblob(&ours, active_cache[pos+1]->sha1);
read_mmblob(&theirs, active_cache[pos+2]->sha1); read_mmblob(&theirs, active_cache[pos+2]->sha1);
/*
* NEEDSWORK: re-create conflicts from merges with
* merge.renormalize set, too
*/
status = ll_merge(&result_buf, path, &ancestor, "base", status = ll_merge(&result_buf, path, &ancestor, "base",
&ours, "ours", &theirs, "theirs", 0); &ours, "ours", &theirs, "theirs", 0);
free(ancestor.ptr); free(ancestor.ptr);

6
ll-merge.c
View File

@ -99,8 +99,8 @@ static int ll_union_merge(const struct ll_merge_driver *drv_unused,
int flag, int marker_size) int flag, int marker_size)
{ {
/* Use union favor */ /* Use union favor */
flag = (flag & LL_OPT_VIRTUAL_ANCESTOR) | flag &= ~LL_OPT_FAVOR_MASK;
create_ll_flag(XDL_MERGE_FAVOR_UNION); flag |= create_ll_flag(XDL_MERGE_FAVOR_UNION);
return ll_xdl_merge(drv_unused, result, path_unused, return ll_xdl_merge(drv_unused, result, path_unused,
orig, NULL, src1, NULL, src2, NULL, orig, NULL, src1, NULL, src2, NULL,
flag, marker_size); flag, marker_size);
@ -345,7 +345,7 @@ int ll_merge(mmbuffer_t *result_buf,
const struct ll_merge_driver *driver; const struct ll_merge_driver *driver;
int virtual_ancestor = flag & LL_OPT_VIRTUAL_ANCESTOR; int virtual_ancestor = flag & LL_OPT_VIRTUAL_ANCESTOR;
if (merge_renormalize) { if (flag & LL_OPT_RENORMALIZE) {
normalize_file(ancestor, path); normalize_file(ancestor, path);
normalize_file(ours, path); normalize_file(ours, path);
normalize_file(theirs, path); normalize_file(theirs, path);

1
ll-merge.h
View File

@ -8,6 +8,7 @@
#define LL_OPT_VIRTUAL_ANCESTOR (1 << 0) #define LL_OPT_VIRTUAL_ANCESTOR (1 << 0)
#define LL_OPT_FAVOR_MASK ((1 << 1) | (1 << 2)) #define LL_OPT_FAVOR_MASK ((1 << 1) | (1 << 2))
#define LL_OPT_FAVOR_SHIFT 1 #define LL_OPT_FAVOR_SHIFT 1
#define LL_OPT_RENORMALIZE (1 << 3)
static inline int ll_opt_favor(int flag) static inline int ll_opt_favor(int flag)
{ {

1
merge-recursive.c
View File

@ -648,6 +648,7 @@ static int merge_3way(struct merge_options *o,
merge_status = ll_merge(result_buf, a->path, &orig, base_name, merge_status = ll_merge(result_buf, a->path, &orig, base_name,
&src1, name1, &src2, name2, &src1, name1, &src2, name2,
((o->call_depth ? LL_OPT_VIRTUAL_ANCESTOR : 0) | ((o->call_depth ? LL_OPT_VIRTUAL_ANCESTOR : 0) |
(o->renormalize ? LL_OPT_RENORMALIZE : 0) |
create_ll_flag(favor))); create_ll_flag(favor)));
free(name1); free(name1);

15
rerere.c
View File

@ -319,6 +319,10 @@ static int handle_cache(const char *path, unsigned char *sha1, const char *outpu
if (!mmfile[i].ptr && !mmfile[i].size) if (!mmfile[i].ptr && !mmfile[i].size)
mmfile[i].ptr = xstrdup(""); mmfile[i].ptr = xstrdup("");
} }
/*
* NEEDSWORK: handle conflicts from merges with
* merge.renormalize set, too
*/
ll_merge(&result, path, &mmfile[0], NULL, ll_merge(&result, path, &mmfile[0], NULL,
&mmfile[1], "ours", &mmfile[1], "ours",
&mmfile[2], "theirs", 0); &mmfile[2], "theirs", 0);
@ -361,7 +365,7 @@ static int find_conflict(struct string_list *conflict)
return 0; return 0;
} }
static int merge(const char *name, const char *path) static int merge(const char *name, int renormalize, const char *path)
{ {
int ret; int ret;
mmfile_t cur = {NULL, 0}, base = {NULL, 0}, other = {NULL, 0}; mmfile_t cur = {NULL, 0}, base = {NULL, 0}, other = {NULL, 0};
@ -376,7 +380,8 @@ static int merge(const char *name, const char *path)
ret = 1; ret = 1;
goto out; goto out;
} }
ret = ll_merge(&result, path, &base, NULL, &cur, "", &other, "", 0); ret = ll_merge(&result, path, &base, NULL, &cur, "", &other, "",
renormalize ? LL_OPT_RENORMALIZE : 0);
if (!ret) { if (!ret) {
FILE *f = fopen(path, "w"); FILE *f = fopen(path, "w");
if (!f) if (!f)
@ -424,7 +429,7 @@ static int update_paths(struct string_list *update)
return status; return status;
} }
static int do_plain_rerere(struct string_list *rr, int fd) static int do_plain_rerere(struct string_list *rr, int fd, int renormalize)
{ {
struct string_list conflict = { NULL, 0, 0, 1 }; struct string_list conflict = { NULL, 0, 0, 1 };
struct string_list update = { NULL, 0, 0, 1 }; struct string_list update = { NULL, 0, 0, 1 };
@ -469,7 +474,7 @@ static int do_plain_rerere(struct string_list *rr, int fd)
const char *name = (const char *)rr->items[i].util; const char *name = (const char *)rr->items[i].util;
if (has_rerere_resolution(name)) { if (has_rerere_resolution(name)) {
if (!merge(name, path)) { if (!merge(name, renormalize, path)) {
if (rerere_autoupdate) if (rerere_autoupdate)
string_list_insert(path, &update); string_list_insert(path, &update);
fprintf(stderr, fprintf(stderr,
@ -553,7 +558,7 @@ int rerere(int flags)
fd = setup_rerere(&merge_rr, flags); fd = setup_rerere(&merge_rr, flags);
if (fd < 0) if (fd < 0)
return 0; return 0;
return do_plain_rerere(&merge_rr, fd); return do_plain_rerere(&merge_rr, fd, merge_renormalize);
} }
static int rerere_forget_one_path(const char *path, struct string_list *rr) static int rerere_forget_one_path(const char *path, struct string_list *rr)