From 6e7e87c762fb0d8aa21c96c1d2c4596e46f2ab7b Mon Sep 17 00:00:00 2001
From: Paul Mackerras <paulus@samba.org>
Date: Tue, 2 Dec 2008 09:17:46 +1100
Subject: [PATCH] gitk: Fix bug in accessing undefined "notflag" variable
As pointed out by Johannes Sixt and Alexander Gavrilov, commit
2958228430b63f2e38c55519d1f98d8d6d9e23f3 ("gitk: Fix switch statement
in parseviewargs") exposed a latent bug in that $notflag was never
initialized. Since it isn't used either, this removes it entirely.
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
gitk | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/gitk b/gitk
index 52d8aaef895..b7447f91c0a 100755
--- a/gitk
+++ b/gitk
@@ -199,11 +199,7 @@ proc parseviewargs {n arglist} {
set nextisval 1
lappend glflags $arg
}
- "--not" {
- set notflag [expr {!$notflag}]
- lappend revargs $arg
- }
- "--all" {
+ "--not" - "--all" {
lappend revargs $arg
}
"--merge" {