From db7879438f0a3d7607555cf166b42ed1083272b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Scharfe?= <l.s.r@web.de> Date: Sat, 4 Oct 2014 10:41:13 +0200 Subject: [PATCH] mailsplit: remove unnecessary unlink(2) call The output file hasn't been created at this point, yet, so there is no need to delete it when exiting early. Suggested-by: Jeff King <peff@peff.net> Signed-off-by: Rene Scharfe <l.s.r@web.de> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- builtin/mailsplit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/builtin/mailsplit.c b/builtin/mailsplit.c index 763cda098cf..8e02ea109ac 100644 --- a/builtin/mailsplit.c +++ b/builtin/mailsplit.c @@ -59,7 +59,6 @@ static int split_one(FILE *mbox, const char *name, int allow_bare) int is_bare = !is_from_line(buf.buf, buf.len); if (is_bare && !allow_bare) { - unlink(name); fprintf(stderr, "corrupt mailbox\n"); exit(1); }