Jonathan Nieder 349362cc20 xdiff: cast arguments for ctype functions to unsigned char ...

The ctype functions isspace(), isalnum(), et al take an integer
argument representing an unsigned character, or -1 for EOF.  On
platforms with a signed char, it is unsafe to pass a char to them
without casting it to unsigned char first.

Most of git is already shielded against this by the ctype
implementation in git-compat-util.h, but xdiff, which uses libc
ctype.h, ought to be fixed.

Noticed-by: der Mouse <mouse@Rodents-Montreal.ORG>
Reported-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2010-10-06 10:46:45 -07:00

..

xdiff.h

xdl_merge(): move file1 and file2 labels to xmparam structure

2010-03-20 20:36:10 -07:00

xdiffi.c

refactor: use bitsizeof() instead of 8 * sizeof()

2009-07-22 21:57:41 -07:00

xdiffi.h

Implement the patience diff algorithm

2009-01-07 13:35:44 -08:00

xemit.c

Fix various dead stores found by the clang static analyzer

2009-03-15 18:25:24 -07:00

xemit.h

Allow alternate "low-level" emit function from xdl_diff

2008-10-25 12:09:31 -07:00

xinclude.h

…

xmacros.h

xdiff: cast arguments for ctype functions to unsigned char

2010-10-06 10:46:45 -07:00

xmerge.c

xdiff: cast arguments for ctype functions to unsigned char

2010-10-06 10:46:45 -07:00

xpatience.c

Implement the patience diff algorithm

2009-01-07 13:35:44 -08:00

xprepare.c

Implement the patience diff algorithm

2009-01-07 13:35:44 -08:00

xprepare.h

…

xtypes.h

…

xutils.c

xdiff: cast arguments for ctype functions to unsigned char

2010-10-06 10:46:45 -07:00

xutils.h

…