1
0
mirror of https://github.com/git/git.git synced 2025-04-05 08:28:36 +00:00
Jakub Narebski b13e3eacef gitweb: Fix fallback mode of to_utf8 subroutine
e5d3de5 (gitweb: use Perl built-in utf8 function for UTF-8 decoding.,
2007-12-04) was meant to make gitweb faster by using Perl's internals
(see subsection "Messing with Perl's Internals" in Encode(3pm) manpage)

Simple benchmark confirms that (old = 00f429a, new = this version):

        old  new
  old    -- -65%
  new  189%   --

Unfortunately it made fallback mode of to_utf8 do not work...  except
for default value 'latin1' of $fallback_encoding ('latin1' is Perl
native encoding), which is why it was not noticed for such long time.

utf8::valid(STRING) is an internal function that tests whether STRING
is in a _consistent state_ regarding UTF-8.  It returns true is
well-formed UTF-8 and has the UTF-8 flag on _*or*_ if string is held
as bytes (both these states are 'consistent').  For gitweb the second
option was true, as output from git commands is opened without ':utf8'
layer.

What made it work at all for STRING in 'latin1' encoding is the fact
that utf8:decode(STRING) turns on UTF-8 flag only if source string is
valid UTF-8 and contains multi-byte UTF-8 characters... and that if
string doesn't have UTF-8 flag set it is treated as in native Perl
encoding, i.e.  'latin1' / 'iso-8859-1' (unless native encoding it is
EBCDIC ;-)).  It was ':utf8' layer that actually converted 'latin1'
(no UTF-8 flag == native == 'latin1) to 'utf8'.

Let's make use of the fact that utf8:decode(STRING) returns false if
STRING is invalid as UTF-8 to check whether to enable fallback mode.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-12-19 12:25:43 -08:00
2011-12-02 10:02:52 -08:00
2011-10-16 03:01:44 -07:00
2011-10-18 12:00:33 -07:00
2011-09-27 17:00:06 -07:00
2011-09-16 21:47:47 -07:00
2011-10-21 16:04:32 -07:00
2011-10-21 16:04:32 -07:00
2011-05-09 16:29:46 -07:00
2011-07-19 09:54:51 -07:00
2011-10-21 16:04:32 -07:00
2011-10-07 15:46:14 -07:00
2011-05-26 16:47:15 -07:00
2011-08-11 12:21:07 -07:00
2011-10-05 12:36:17 -07:00
2011-09-19 20:46:48 -07:00
2011-12-02 10:02:52 -08:00
2011-08-20 22:33:58 -07:00
2011-07-22 14:43:21 -07:00
2011-10-17 21:37:15 -07:00
2011-11-15 16:08:48 -08:00
2011-11-08 13:37:10 -08:00
2011-08-20 22:33:57 -07:00
2011-05-19 18:23:17 -07:00
2011-10-18 21:59:12 -07:00
2011-11-18 11:14:00 -08:00
2011-11-18 11:30:02 -08:00
2011-08-22 10:07:07 -07:00
2011-08-18 14:17:12 -07:00
2011-09-28 12:46:21 -07:00
2011-10-04 13:30:38 -07:00
2011-11-16 21:52:24 -08:00
2011-10-21 16:04:36 -07:00
2011-11-18 11:28:05 -08:00
2011-10-26 16:16:29 -07:00
2011-10-26 16:16:29 -07:00
2011-05-30 00:09:55 -07:00
2011-11-15 16:09:20 -08:00
2011-08-01 15:00:29 -07:00
2011-05-26 16:47:15 -07:00
2011-10-10 15:56:20 -07:00
2011-10-05 12:36:20 -07:00
2011-10-17 21:37:15 -07:00
2011-05-26 13:54:18 -07:00

////////////////////////////////////////////////////////////////

	GIT - the stupid content tracker

////////////////////////////////////////////////////////////////

"git" can mean anything, depending on your mood.

 - random three-letter combination that is pronounceable, and not
   actually used by any common UNIX command.  The fact that it is a
   mispronunciation of "get" may or may not be relevant.
 - stupid. contemptible and despicable. simple. Take your pick from the
   dictionary of slang.
 - "global information tracker": you're in a good mood, and it actually
   works for you. Angels sing, and a light suddenly fills the room.
 - "goddamn idiotic truckload of sh*t": when it breaks

Git is a fast, scalable, distributed revision control system with an
unusually rich command set that provides both high-level operations
and full access to internals.

Git is an Open Source project covered by the GNU General Public License.
It was originally written by Linus Torvalds with help of a group of
hackers around the net. It is currently maintained by Junio C Hamano.

Please read the file INSTALL for installation instructions.

See Documentation/gittutorial.txt to get started, then see
Documentation/everyday.txt for a useful minimum set of commands, and
Documentation/git-commandname.txt for documentation of each command.
If git has been correctly installed, then the tutorial can also be
read with "man gittutorial" or "git help tutorial", and the
documentation of each command with "man git-commandname" or "git help
commandname".

CVS users may also want to read Documentation/gitcvs-migration.txt
("man gitcvs-migration" or "git help cvs-migration" if git is
installed).

Many Git online resources are accessible from http://git-scm.com/
including full documentation and Git related tools.

The user discussion and development of Git take place on the Git
mailing list -- everyone is welcome to post bug reports, feature
requests, comments and patches to git@vger.kernel.org. To subscribe
to the list, send an email with just "subscribe git" in the body to
majordomo@vger.kernel.org. The mailing list archives are available at
http://marc.theaimsgroup.com/?l=git and other archival sites.

The messages titled "A note from the maintainer", "What's in
git.git (stable)" and "What's cooking in git.git (topics)" and
the discussion following them on the mailing list give a good
reference for project status, development direction and
remaining tasks.
Description
Git Source Code Mirror - This is a publish-only repository but pull requests can be turned into patches to the mailing list via GitGitGadget (https://gitgitgadget.github.io/). Please follow Documentation/SubmittingPatches procedure for any of your improvements.
Readme 809 MiB
Languages
C 50.1%
Shell 38.4%
Perl 5.1%
Tcl 3.2%
Python 0.8%
Other 2.1%